----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/#review217542 -----------------------------------------------------------
cmake/distcheck.sh Lines 22 (patched) <https://reviews.apache.org/r/71241/#comment304796> Probably makes no difference, but `mesos-${VERSION}` looks a bit safer. cmake/distcheck.sh Lines 25 (patched) <https://reviews.apache.org/r/71241/#comment304795> I don't think we should unconditionally override the users environment like this in a support script - there's no guarantee that `clang` or `ccache` are even installed. If we have to specify `CMAKE_CXX_COMPILER` etc. at all, we should probably use `${CXX}` as default value and make sure that cmake sets the correct values when invoking the script. - Benno Evers On Aug. 6, 2019, 7:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71241/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2019, 7:28 p.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This patch adds a `distcheck` target to the cmake build which mimics the > target of the same name provided by the autotools build. `distcheck` > depends on the `dist` target to create a distribution archive and then > ensures that with the distributed sources the `check` targets succeeds. > > > Diffs > ----- > > CMakeLists.txt 65bfbac0e2b6aec26a6d98ff96615661210ceac2 > cmake/distcheck.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/71241/diff/1/ > > > Testing > ------- > > `ninja distcheck` passes, no artifacts left around but tarball. > > > Thanks, > > Benjamin Bannier > >
