----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71428/#review217560 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp Line 2372 (original), 2370 (patched) <https://reviews.apache.org/r/71428/#comment304820> Now that we are actually using `Slave::getOfferedOrAllocated()`, this line makes me worry about the test coverage of the per-framework tracking in `Slave`. Specifically, I've tried to break the code in `Slave::increaseAvailable()` added in your previous patch which decreases frameork's offeredOrAllocated and removes a framework if nothing is left - but no test failed. Looks like we are missing a maintenance test which will do something like this: - allocator generates an offer for a slave - framework declines that offer - maintenance is initialed for that slave - framework gets no inverse offers anyway (Probably we need more than one test of this kind.) - Andrei Sekretenko On Sept. 3, 2019, 8:50 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71428/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2019, 8:50 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This paves the way for removing the allocation info tracking > in the sorter (in favor of tracking them in the allocator). > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 187de173ee2f563e2ff0f7e5c96695dd94a73970 > src/master/allocator/mesos/sorter/drf/sorter.hpp > f157ec6153325b0457ab1bc76f9eb018712d753a > src/master/allocator/mesos/sorter/drf/sorter.cpp > 09889cdf3dc8c0e773b8e2e24154fb0edd2cc254 > src/master/allocator/mesos/sorter/random/sorter.hpp > 8663ccd4ccdd36c8ea7513b492d3f46a0b15ff5c > src/master/allocator/mesos/sorter/random/sorter.cpp > 60a5797472460a8d3d9be938af9f6711ea51d484 > src/master/allocator/mesos/sorter/sorter.hpp > 52b8a7b57bf17759311b32aa56c26e614119b773 > src/tests/sorter_tests.cpp 97ab910cac6e0323012bf229ec32669ea374546a > > > Diff: https://reviews.apache.org/r/71428/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
