----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71240/#review217577 -----------------------------------------------------------
Ship it! Ship It! - Till Toenshoff On Sept. 3, 2019, 1:52 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71240/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2019, 1:52 p.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This patch adds a `dist` target to the cmake build, analogous to the > target provided by the autotools build. > > While cmake already provides a `package_source` target to create a > source archive it does not take care of only including relevant files, > but instead adds all files to the archive, e.g., including build or > backup files which should not be part of a release. For that reason this > patch introduces a script which performs a temporary `git clone` from > the checked out git repository and creates the archive from that clean > tree. > > This patch also removes a hardcoded list of ignored files which was > by design not exhaustive. > > > Diffs > ----- > > CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a > cmake/dist.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/71240/diff/2/ > > > Testing > ------- > > `ninja dist` produces a tarball, no artifacts left around but tarball. > > > Thanks, > > Benjamin Bannier > >
