> On Sept. 2, 2019, 2:41 p.m., Benjamin Bannier wrote: > > support/snapshot.sh > > Line 35 (original), 33 (patched) > > <https://reviews.apache.org/r/71392/diff/1/?file=2163061#file2163061line35> > > > > With this change this script becomes really weird. Do we really want to > > get `VERSION` from `configure.ac` so we can update the version in > > `configure.ac`? > > > > Did you mean to get e.g., get a version from `git` instead? I'd imagine > > snapshots like `master-d7286896411` or `1.8.x-d7286896411` could be useful.
I missed that you appended `SNAPSHOT` to `$VERSION` so this isn't fully circular. Dropping. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71392/#review217530 ----------------------------------------------------------- On Aug. 28, 2019, 6:39 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71392/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2019, 6:39 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Bugs: MESOS-9955 > https://issues.apache.org/jira/browse/MESOS-9955 > > > Repository: mesos > > > Description > ------- > > Previously the script expected the version to be provided as an > argument. > > > Diffs > ----- > > support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 > > > Diff: https://reviews.apache.org/r/71392/diff/1/ > > > Testing > ------- > > https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console > > > Thanks, > > Vinod Kone > >
