----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71424/#review217589 -----------------------------------------------------------
Ship it! Looks great. A few more things to think about would be renaming `mock` to something more immediately understandable (or even split this in a separate function, since `bool` parameters are usually a bit of a code smell), however there's no reason that this would need to be done as part of this review. - Benno Evers On Sept. 5, 2019, 2 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71424/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2019, 2 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, > Gilbert Song, Greg Mann, James Peach, Joseph Wu, Meng Zhu, Qian Zhang, and > Till Toenshoff. > > > Bugs: MESOS-9914 > https://issues.apache.org/jira/browse/MESOS-9914 > > > Repository: mesos > > > Description > ------- > > This patch introduces a `SlaveOptions` struct which holds optional > parameters accepted by `cluster::Slave::create`. Added an overload > of `StartSlave` that accepts `SlaveOptions`. It's a preferred way of > creating and starting an instance of `cluster::Slave` in tests, since > underlying `cluster::Slave::create` accepts a long list of optional > arguments, which might be extended in the future. > > > Diffs > ----- > > src/tests/mesos.hpp 25359a24955fbe6413b3354aabf444818b58cb76 > src/tests/mesos.cpp 0396ce78b13e76cfe2596f0f92ddf9dcccc82fca > > > Diff: https://reviews.apache.org/r/71424/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Andrei Budnik > >
