----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71440/#review217608 -----------------------------------------------------------
Fix it, then Ship it! I'd suggest being more specific in the description: s/will not get inverse offers/will not get inverse offers for that agent src/tests/hierarchical_allocator_tests.cpp Line 1095 (original), 1127 (patched) <https://reviews.apache.org/r/71440/#comment304876> We don't call `updateUnavalability` for agent2 (the slave for which we declined an offer) - is this test really able to catch broken `Slave::increaseAvailable()`?... - Andrei Sekretenko On Sept. 5, 2019, 9:12 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71440/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2019, 9:12 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > The test is augmented to also check that a framework that > declined offers from an agent will not get inverse offers. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 2c1d0fe2e3ac08e6443cf8348bb72ac7dae454a8 > > > Diff: https://reviews.apache.org/r/71440/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
