----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71434/#review217620 -----------------------------------------------------------
Ship it! Ship It! - Meng Zhu On Sept. 6, 2019, 9:55 a.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71434/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2019, 9:55 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-1452 and MESOS-9949 > https://issues.apache.org/jira/browse/MESOS-1452 > https://issues.apache.org/jira/browse/MESOS-9949 > > > Repository: mesos > > > Description > ------- > > This patch moves offer removal on accept into the deferred continuation > that follows authorization (if offers pass validation in `accept()`). > > Incrementing the `offers_accepted` metric is also moved to `_accept()`. > > This is a prerequisite for implementing `rescindOffer()` / > `declineOffer()` / in the dependent patch. > > > Diffs > ----- > > src/master/master.hpp 19c17821d2b8111ebe8e1429a5b4a8423357fdd6 > src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b > > > Diff: https://reviews.apache.org/r/71434/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
