----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71460/ -----------------------------------------------------------
(Updated Sept. 11, 2019, 3:52 p.m.) Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Changes ------- Documented that shared resources must be uniquely identifiable. Repository: mesos Description (updated) ------- This helpers simplify the quota tracking logic and also paves the way to reduce duplicated states in the sorter. Also documented that shared resources must be uniquely identifiable. Small performance degradation when making allocations due to duplicated map construction in `(un)trackAllocatedResources`. This will be removed once embeded the sorter in the role tree. Benchmark `LargeAndSmallQuota/2`: Master: Added 3000 agents in 80.648188ms Added 3000 frameworks in 19.7006984secs Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with drf sorter Made 3500 allocations in 16.044274434secs Made 0 allocation in 14.476429451secs Master + this patch: Added 3000 agents in 80.110817ms Added 3000 frameworks in 17.25974094secs Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with drf sorter Made 3500 allocations in 16.91971379secs Made 0 allocation in 13.784476154secs Diffs (updated) ----- include/mesos/mesos.proto 8fd838e96228daacb0a1c0f4890fd3630841ab52 include/mesos/v1/mesos.proto da19256cbb53215dc6f51d809ad214683ea153cf src/master/allocator/mesos/hierarchical.hpp 48ba399e12129b3348b5c43b793f3428acf26d4e src/master/allocator/mesos/hierarchical.cpp 187de173ee2f563e2ff0f7e5c96695dd94a73970 Diff: https://reviews.apache.org/r/71460/diff/3/ Changes: https://reviews.apache.org/r/71460/diff/2-3/ Testing ------- make check Benchmark result in the description Thanks, Meng Zhu
