----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71480/#review217716 -----------------------------------------------------------
Patch looks great! Reviews applied: [71480] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 12, 2019, 11:18 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71480/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2019, 11:18 p.m.) > > > Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-9965 > https://issues.apache.org/jira/browse/MESOS-9965 > > > Repository: mesos > > > Description > ------- > > Previously, the agent would send task status updates with the state > TASK_GONE_BY_OPERATOR to all schedulers when an agent was drained > with the `mark_gone` parameter set to `true`. > > This patch updates this code to ensure that TASK_GONE_BY_OPERATOR > is only sent to partition-aware schedulers. > > > Diffs > ----- > > src/slave/slave.cpp 4e9365669395c89202961ca80d41cd92346d23d2 > src/tests/slave_tests.cpp 02b65a925a52d09b0a9183d3288b9ab363b98bc5 > > > Diff: https://reviews.apache.org/r/71480/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
