----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217786 -----------------------------------------------------------
Patch looks great! Reviews applied: [71496, 71497] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 17, 2019, 12:50 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71497/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2019, 12:50 p.m.) > > > Review request for mesos, Greg Mann and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > The `LIBPROCESS_SSL_REQUIRE_CERT` flag was renamed to > `LIBPROCESS_SSL_REQUIRE_CLIENT_CERT`. > > The `LIBPROCESS_SSL_VERIFY_CERT` flag was renamed to > `LIBPROCESS_SSL_VERIFY_SERVER_CERT`. > > The new names better describe the actual effect of both flags, and > make upgrades easier by allowing operators to only enable verification > on agents that are new enough to contain the updated hostname > validation code paths. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/flags.hpp > 1a0e3820cc8cd1459625f46a54b194133500f11e > 3rdparty/libprocess/src/openssl.hpp > 271cc95238d287c06df36478554502e8b7205b09 > 3rdparty/libprocess/src/openssl.cpp > 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 9d5ab679165a709f7c3740020961ec89a7db4f54 > docs/ssl.md 90a2eb9800b7d8d9aa9d7b1060a6e5eb9e124b02 > > > Diff: https://reviews.apache.org/r/71497/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
