----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review217795 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/hierarchical.hpp Lines 261 (patched) <https://reviews.apache.org/r/71498/#comment305184> why not take in a `Role*`? It's one less lookup and clearly shifts the burden of `CHECK` to the caller. I think the value of this helper is to eliminate the pointer invovled loop. Taking the string is not necessary. - Meng Zhu On Sept. 17, 2019, 6:25 a.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71498/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2019, 6:25 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9949 > https://issues.apache.org/jira/browse/MESOS-9949 > > > Repository: mesos > > > Description > ------- > > Introduced a role tree helper to modify a role and all its ancestors. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 5ea37912dadded47eaa2d354889c95533b191c59 > src/master/allocator/mesos/hierarchical.cpp > 256fdce61ccfb768605cac1579c9a6632cd26fec > > > Diff: https://reviews.apache.org/r/71498/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
