> On Sept. 18, 2019, 1:07 p.m., Benjamin Bannier wrote: > > CMakeLists.txt > > Lines 100 (patched) > > <https://reviews.apache.org/r/71507/diff/1/?file=2165720#file2165720line100> > > > > This is consistent with how we do it elsewhere, but I wonder: is the > > reason we cannot have these targets here due to shell scripts not being > > available on the Windows _platform_, or due to the default _generator_ on > > Windows not supporting them (i.e., would this e.g., work when building with > > Ninja on Windows). Maybe you could leave a comment with a hint why we > > disable them here.
The default way to handle `add_custom_target(... COMMAND ...)` depends on the platform. On Windows, it will attempt to run the command with `cmd`, which won't work. So this doesn't have much to do with the chosen generator. It might be possible for a different generator to try appending `bash` instead of `cmd`. But the existence of `bash` on Windows is not guaranteed. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71507/#review217830 ----------------------------------------------------------- On Sept. 18, 2019, 12:26 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71507/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2019, 12:26 p.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-9971 > https://issues.apache.org/jira/browse/MESOS-9971 > > > Repository: mesos > > > Description > ------- > > The targets are implemented with shell scripts, so do not work > on Windows. The targets are also currently unneeded for the Windows > build. > > > Diffs > ----- > > CMakeLists.txt a1ca5c28819b946b10a3533f4793896c676d4682 > > > Diff: https://reviews.apache.org/r/71507/diff/1/ > > > Testing > ------- > > cmake --build . --target dist > > > Thanks, > > Joseph Wu > >
