----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71478/#review217838 -----------------------------------------------------------
Ship it! Ship It! - Greg Mann On Sept. 12, 2019, 7:35 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71478/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2019, 7:35 p.m.) > > > Review request for mesos, Greg Mann and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > MSVC does not deal with #ifdefs from inside function calls. > So here, the `#if defined(...)` was taken literally and is > considered a syntax error by MSVC. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.cpp > 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6 > > > Diff: https://reviews.apache.org/r/71478/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
