----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71516/ -----------------------------------------------------------
(Updated Sept. 18, 2019, 8:41 p.m.) Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Changes ------- Added benchmark result in the description. Repository: mesos Description (updated) ------- A framework is tracked under the role if the framework: (1) is subscribed to the role; Or (2) has resources allocated under the role. (2) could be true without (1). This is because we allow frameworks to update their roles without revoking their allocated or offered resources. This patch recognizes this fact and encapsulates the related checks in the helper. Benchmark result: no major performance impact. Master BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 Added 3000 agents in 90.816373ms Added 3000 frameworks in 17.202199348secs Made 3500 allocations in 15.46714944secs Made 0 allocation in 13.767830924secs Master + this patch: BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 Added 3000 agents in 86.782773ms Added 3000 frameworks in 18.174924815secs Made 3500 allocations in 15.813011454secs Made 0 allocation in 12.882917161secs Diffs (updated) ----- src/master/allocator/mesos/hierarchical.hpp 5ea37912dadded47eaa2d354889c95533b191c59 src/master/allocator/mesos/hierarchical.cpp 256fdce61ccfb768605cac1579c9a6632cd26fec Diff: https://reviews.apache.org/r/71516/diff/2/ Changes: https://reviews.apache.org/r/71516/diff/1-2/ Testing ------- make check Thanks, Meng Zhu
