> On Sept. 18, 2019, 10:43 a.m., Andrei Sekretenko wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1489-1494 (original), 1523-1528 (patched) > > <https://reviews.apache.org/r/71476/diff/1/?file=2164947#file2164947line1524> > > > > Previously, this code was executed even in case of recovering resources > > of already removed slave. > > > > Now I don't see any framework untracking code in `removeSlave()` or > > `untrackAllocatedResources()`. > > > > Does this mean that now we are potentially leaking frameworks? Or not?
That's a very good point! I refactored (un)trackFrameworkUnderRole in dependecy patches. It should be more intuitive now. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71476/#review217826 ----------------------------------------------------------- On Sept. 12, 2019, 3:42 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71476/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2019, 3:42 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-621 > https://issues.apache.org/jira/browse/MESOS-621 > > > Repository: mesos > > > Description > ------- > > Simplified recover resources when removing frameworks or agents. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 5ea37912dadded47eaa2d354889c95533b191c59 > src/master/allocator/mesos/hierarchical.cpp > 256fdce61ccfb768605cac1579c9a6632cd26fec > src/master/master.cpp a2c289a8b6e30eac690f77c7fc1b12b16f62f541 > > > Diff: https://reviews.apache.org/r/71476/diff/1/ > > > Testing > ------- > > make check > New test in https://reviews.apache.org/r/71479/ > > > Thanks, > > Meng Zhu > >
