----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71522/#review217888 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/jsonify.hpp Line 658 (original), 658 (patched) <https://reviews.apache.org/r/71522/#comment305267> For consistency, I'd suggest either adding this to the constructor of `WriterProxy` or adding a member initializer for `writer_` in the line above as well. - Benno Evers On Sept. 20, 2019, 7:53 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71522/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2019, 7:53 a.m.) > > > Review request for mesos, Benno Evers and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added missing member initialization in `JSON::WriterProxy`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/jsonify.hpp > e5402b788dd8d539a7889c390a66abb3b36faca9 > > > Diff: https://reviews.apache.org/r/71522/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
