----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71455/#review217908 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_tests.cpp Line 2789 (original), 2795-2796 (patched) <https://reviews.apache.org/r/71455/#comment305281> Please add a description for this test. src/tests/slave_tests.cpp Lines 2802 (patched) <https://reviews.apache.org/r/71455/#comment305282> I see you explicitly create POSIX launcher in the code below, so why do we need this line? src/tests/slave_tests.cpp Lines 2914 (patched) <https://reviews.apache.org/r/71455/#comment305283> Nit: enclose `/containerizer/debug` in ``. - Qian Zhang On Sept. 9, 2019, 10:53 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71455/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2019, 10:53 p.m.) > > > Review request for mesos, Gilbert Song, Joseph Wu, and Qian Zhang. > > > Bugs: MESOS-9843 > https://issues.apache.org/jira/browse/MESOS-9843 > > > Repository: mesos > > > Description > ------- > > This test starts an agent with the MockIsolator to intercept calls to > its `prepare` method, then it launches a task, which gets stuck. > We check that the /containerizer/debug endpoint returns a non-empty > list of pending futures including `MockIsolator::prepare`. After > setting the promise for the `prepare`, the task successfully starts > and we expect for the /containerizer/debug endpoint to return an > empty list of pending operations. > > > Diffs > ----- > > src/tests/slave_tests.cpp 02b65a925a52d09b0a9183d3288b9ab363b98bc5 > > > Diff: https://reviews.apache.org/r/71455/diff/2/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
