----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71535/#review217921 -----------------------------------------------------------
Patch looks great! Reviews applied: [71535] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 24, 2019, 12:41 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71535/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2019, 12:41 a.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The former implementation failed on Windows. By switching > to the recommended `BIO_` API for serializing the x509 data > to disk, we avoid that problem. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/utilities.cpp > c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48 > > > Diff: https://reviews.apache.org/r/71535/diff/2/ > > > Testing > ------- > > Tested "manually" within a private project on Windows. > > > Thanks, > > Till Toenshoff > >
