----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71547/#review217949 -----------------------------------------------------------
Patch looks great! Reviews applied: [71546, 71547] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 25, 2019, 10:30 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71547/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2019, 10:30 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Now allocated or offered resources are tracked in the slave > struct, we no longer need to look up states in the sorter > when removing frameworks. This patch makes the framework > removal logic more simpler by doing this. > > This also paves the way to deprecate the framework sorter. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > d42124f534536ad044bff9878d242892fa042f24 > src/master/allocator/mesos/hierarchical.cpp > 47281542792486854b71c7e75dfa8ea3ee3ef3fc > > > Diff: https://reviews.apache.org/r/71547/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
