----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71546/#review217955 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp Lines 857 (patched) <https://reviews.apache.org/r/71546/#comment305350> why pass it in when we can just retrieve it from slaveInfo? - Benjamin Mahler On Sept. 25, 2019, 10:29 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71546/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2019, 10:29 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Kept SlaveID in the Slave struct in the allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > d42124f534536ad044bff9878d242892fa042f24 > src/master/allocator/mesos/hierarchical.cpp > 47281542792486854b71c7e75dfa8ea3ee3ef3fc > > > Diff: https://reviews.apache.org/r/71546/diff/1/ > > > Testing > ------- > > > Thanks, > > Meng Zhu > >
