----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71501/#review217970 -----------------------------------------------------------
Ship it! I remember we used to fix an similar issue - root container sandbox is not recovered. could you remind me how could we get into this case? - Gilbert Song On Sept. 18, 2019, 3:49 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71501/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2019, 3:49 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-9966 > https://issues.apache.org/jira/browse/MESOS-9966 > > > Repository: mesos > > > Description > ------- > > Gc'ed nested container sandbox only if we have root container sandbox. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 16149a1428db687b131de08d14893a2dd684ce28 > > > Diff: https://reviews.apache.org/r/71501/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
