----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71491/#review218093 -----------------------------------------------------------
Ship it! Nice tests! I will take care of the stuff below before committing. src/tests/consumption_metrics_tests.cpp Lines 108-109 (patched) <https://reviews.apache.org/r/71491/#comment305628> .WillRepeatedly(Return()); // Ignore subsequent offers. - Meng Zhu On Sept. 17, 2019, 6:26 a.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71491/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2019, 6:26 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9123 and MESOS-9949 > https://issues.apache.org/jira/browse/MESOS-9123 > https://issues.apache.org/jira/browse/MESOS-9949 > > > Repository: mesos > > > Description > ------- > > Added tests of metrics for tracking quota consumption. > > > Diffs > ----- > > src/Makefile.am eff0127a0baa7c112db32aa1bd2b35e0d3cb7aee > src/tests/CMakeLists.txt 1e53b396569bf3e2f47199956a630afb6197b992 > src/tests/consumption_metrics_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71491/diff/2/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="*Consumption*" --gtest_break_on_failure > --gtest_repeat=1000` > > > Thanks, > > Andrei Sekretenko > >
