----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71608/#review218194 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/store.cpp Line 354 (original), 348 (patched) <https://reviews.apache.org/r/71608/#comment305749> we dont need this promise in this case. src/slave/containerizer/mesos/provisioner/docker/store.cpp Lines 379 (patched) <https://reviews.apache.org/r/71608/#comment305750> call future.discard() if we remove this promise - Gilbert Song On Oct. 11, 2019, 7:09 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71608/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2019, 7:09 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-9964 > https://issues.apache.org/jira/browse/MESOS-9964 > > > Repository: mesos > > > Description > ------- > > WIP: Supported destroying UCR container in `PROVISIONING` state. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > c61b954635ebcaed3e498452bddeee6e1b34f388 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 > > > Diff: https://reviews.apache.org/r/71608/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
