----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71780/#review218743 -----------------------------------------------------------
Ship it! Logically looks good, but commit could use more context? It makes more sense to be done in the Heartbeater instead of the handler, especially since the heartbeater already supports an initial heartbeat, so maybe just explain that in the commit? I can't remember, was there any other reason to get it out of the handler? (Just curious, do we have a test for an initial heartbeat to show up? Or did you manually test that an initial heartbeat still goes through?) - Benjamin Mahler On Nov. 21, 2019, 9:42 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71780/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2019, 9:42 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Deferred sending of initial heartbeat to Heartbeater. > > > Diffs > ----- > > src/master/http.cpp 1778664dddf19f9ab6d6c09ec35d64674ae488df > src/master/master.hpp 8a140650a016c8afbfb39729eba2b5e78ea81c5f > > > Diff: https://reviews.apache.org/r/71780/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
