----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71754/#review218773 -----------------------------------------------------------
Ship it! Ship It! - Andrei Sekretenko On Nov. 22, 2019, 6:28 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71754/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2019, 6:28 p.m.) > > > Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu. > > > Bugs: MESOS-10026 > https://issues.apache.org/jira/browse/MESOS-10026 > > > Repository: mesos > > > Description > ------- > > This follow the same approach used in the GetAgents call; > serializing directly to protobuf or json from the in-memory > v0 state. > > Before: > v0 '/state' response took 6.55 secs > v1 'GetState' application/x-protobuf response took 24.08 secs > v1 'GetState' application/json response took 22.76 secs > > After: > v0 '/state' response took 8.00 secs > v1 'GetState' application/x-protobuf response took 5.73 secs > v1 'GetState' application/json response took 9.62 secs > > > Diffs > ----- > > src/master/http.cpp 1778664dddf19f9ab6d6c09ec35d64674ae488df > src/master/master.hpp 8a140650a016c8afbfb39729eba2b5e78ea81c5f > > > Diff: https://reviews.apache.org/r/71754/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
