----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/#review218780 -----------------------------------------------------------
Patch looks great! Reviews applied: [71742] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 22, 2019, 8:02 p.m., Xudong Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71742/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2019, 8:02 p.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu. > > > Bugs: MESOS-10032 > https://issues.apache.org/jira/browse/MESOS-10032 > > > Repository: mesos > > > Description > ------- > > In the case agents lost ZooKeeper connections and resetting its > master to none and beginning to dropping control messages from the > master, agent should not respond pings from master. > > > Diffs > ----- > > src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 > src/tests/slave_recovery_tests.cpp 0efd3a6ac09ad06d9365b7bb2295157b5175e6b8 > > > Diff: https://reviews.apache.org/r/71742/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Xudong Ni > >