----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71816/#review218799 -----------------------------------------------------------
Patch looks great! Reviews applied: [71816] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 25, 2019, 5 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71816/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2019, 5 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-10035 > https://issues.apache.org/jira/browse/MESOS-10035 > > > Repository: mesos > > > Description > ------- > > Added two new flags `http_executor_domain_sockets` and > `domain_socket_location` to the agent, along with minimal > logic to pass the relevant values on to executors. > > They are used to control whether the agent should > provide a domain socket to HTTP executors and the > location of the socket on the host filesystem, respectively. > > > Diffs > ----- > > src/slave/flags.hpp 3c5ffca62454c340656cfc89c53a198757815794 > src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222 > src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 > > > Diff: https://reviews.apache.org/r/71816/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
