----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71827/#review218811 -----------------------------------------------------------
Patch looks great! Reviews applied: [71823, 71824, 71825, 71826, 71827] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 26, 2019, 9:31 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71827/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2019, 9:31 p.m.) > > > Review request for mesos, Andrei Sekretenko and Greg Mann. > > > Bugs: MESOS-10026 > https://issues.apache.org/jira/browse/MESOS-10026 > > > Repository: mesos > > > Description > ------- > > This uses the same approach for other GET_ calls in MESOS-10026 > of directly serializing from in-memory state, rather than building > up the temporary object and evolving it. > > There is currently no benchmark but the improvement should closely > resemble that of the GET_STATE call, for example: > > Before: > v0 '/state' response took 6.55 secs > v1 'GetState' application/x-protobuf response took 24.08 secs > v1 'GetState' application/json response took 22.76 secs > > After: > v0 '/state' response took 8.00 secs > v1 'GetState' application/x-protobuf response took 5.73 secs > v1 'GetState' application/json response took 9.62 secs > > > Diffs > ----- > > src/master/http.cpp e03655863ea2d4e4464b3d14b359de3d7f059778 > src/master/master.hpp 93630421d58e6fd26566e81a23cd910957795665 > > > Diff: https://reviews.apache.org/r/71827/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
