----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71832/#review218821 -----------------------------------------------------------
Ship it! Can you add a trivial patch for this (`issocket` for socket returns `true`, for a non-socket returns `false`). - Benjamin Bannier On Nov. 27, 2019, 12:43 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71832/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2019, 12:43 p.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Bugs: MESOS-10036 > https://issues.apache.org/jira/browse/MESOS-10036 > > > Repository: mesos > > > Description > ------- > > Added a new helper 'issocket()' that tells whether a given > file is a socket or not. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/stat.hpp > 74e0c934baa29ec936e8011221a3da29dd67a465 > > > Diff: https://reviews.apache.org/r/71832/diff/1/ > > > Testing > ------- > > Manual testing by using it in the subsequent patch. > > > Thanks, > > Benno Evers > >
