----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71860/#review218917 -----------------------------------------------------------
Same comments from the previous review, around the construction style of ActionObject and avoiding the copy of ActionObject. src/master/master.cpp Lines 2240-2244 (original), 2240-2244 (patched) <https://reviews.apache.org/r/71860/#comment306831> The following wrapping would be in line with our style guide: ``` return authorize( frameworkInfo.has_principal() ? Option<Principal>(frameworkInfo.principal()) : Option<Principal>::none(), ActionObject::frameworkRegistration(frameworkInfo)); ``` - Benjamin Mahler On Dec. 3, 2019, 5:52 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71860/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2019, 5:52 p.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Bugs: MESOS-10023 and MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10023 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > Moved creating authorization Object out of `Master::authorizeFramework`. > > > Diffs > ----- > > src/master/authorization.hpp PRE-CREATION > src/master/authorization.cpp PRE-CREATION > src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 > > > Diff: https://reviews.apache.org/r/71860/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
