-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71859/#review218918
-----------------------------------------------------------
Another observation from a subsequent review with:
```
static std::vector<ActionObject> growVolume(
const Offer::Operation::GrowVolume& grow);
static std::vector<ActionObject> shrinkVolume(
const Offer::Operation::ShrinkVolume& shrink);
```
Why doesn't this patch just take the offer operations for launching tasks?
```
static std::vector<ActionObject> launch(
const Offer::Operation::Launch& launch);
static std::vector<ActionObject> launchGroup(
const Offer::Operation::LaunchGroup& launchGroup);
```
That would look more consistent, and it would pull more logic out of the master
code?
- Benjamin Mahler
On Dec. 3, 2019, 3:02 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71859/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2019, 3:02 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-10023 and MESOS-10056
> https://issues.apache.org/jira/browse/MESOS-10023
> https://issues.apache.org/jira/browse/MESOS-10056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the first patch in the chain that extract Master code
> generating Action-Object pairs into a dedicated ActionObject class,
> thus seperating authz Object creation from feeding them into authorizer.
>
> This is a prerequisite to using ObjectApprover interface for
> synchronous authorization of Scheduler API calls.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ef9382dc77d37fed344b7267119f3251acd3088a
> src/Makefile.am 111c156c8a7abc5ece04779e8ac8879a30c22dbf
> src/common/authorization.hpp 565d5ca6620442803fa80be652ab7382102347f5
> src/common/authorization.cpp fa71b0e8e8b9541376a9fd199f4d7b9db56a3f0f
> src/master/authorization.hpp PRE-CREATION
> src/master/authorization.cpp PRE-CREATION
> src/master/master.hpp 93630421d58e6fd26566e81a23cd910957795665
> src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869
>
>
> Diff: https://reviews.apache.org/r/71859/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
