> On Dec. 5, 2019, 3:12 p.m., Benjamin Bannier wrote: > > src/tests/cluster.cpp > > Lines 630 (patched) > > <https://reviews.apache.org/r/71833/diff/4/?file=2181822#file2181822line630> > > > > There is another, currently unhandled branch where > > `domain_socket_location` exists, but is not a socket. Either we handle that > > case as well, or just check if _something_ exists where we'd expect the > > socket and let this fail later.
I think the latter variant is what the code does, no? If there exists another file that is not a socket, we should end up with an error upon calling `bind()`. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/#review218939 ----------------------------------------------------------- On Dec. 3, 2019, 6:30 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71833/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2019, 6:30 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-10036 > https://issues.apache.org/jira/browse/MESOS-10036 > > > Repository: mesos > > > Description > ------- > > Added agent code to check whether domain socket support is > enabled, and if so to create or open the socket at > MESOS_DOMAIN_SOCKET_LOCATION. > > > Diffs > ----- > > src/local/local.cpp 8ff43618f06463b4ba86b64b25e5de692e406448 > src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 > src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb > src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 > src/tests/cluster.cpp f7bc882a644ec65710ada3d15507e1d4c5ba06f7 > src/tests/mock_slave.cpp 71be957884ea88258ef37e60649e3947e89b12d0 > > > Diff: https://reviews.apache.org/r/71833/diff/4/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
