----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/#review219118 -----------------------------------------------------------
Patch looks great! Reviews applied: [71947] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Jan. 3, 2020, 1:38 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71947/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2020, 1:38 a.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Address handling code for unix domain sockets assumed that > strlen() could be used to compute the name of a unix domain > socket, but that fails for unnamed sockets or in the case > where an abstract domain socket contains embedded null bytes. > > This patch adds a new `length` parameter to correctly handle > these special cases. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > 749498056b52b916dfaf6c85f83ecc05e0d5406c > 3rdparty/libprocess/include/process/network.hpp > 8f48a4a78557309a9b1b00d7defb45eed454b077 > > > Diff: https://reviews.apache.org/r/71947/diff/1/ > > > Testing > ------- > > Ran existing unit tests and verified that the newly added `CHECK()` doesn't > trigger. > > > Thanks, > > Benno Evers > >
