----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71906/#review219119 -----------------------------------------------------------
Ship it! Ship It! - Andrei Sekretenko On Dec. 12, 2019, 11:12 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71906/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2019, 11:12 p.m.) > > > Review request for mesos, Andrei Sekretenko and Greg Mann. > > > Bugs: MESOS-6568 > https://issues.apache.org/jira/browse/MESOS-6568 > > > Repository: mesos > > > Description > ------- > > Per MESOS-6568, the omission of empty repeated fields / maps is > inconsistent with the standard proto3 -> JSON mapping. An empty > array is also more convenient to program against since you don't > need to special case the empty case with an absence check. > > This may break any tests that rely on exact string outputs, but > it generally should not break any logic. > > > Diffs > ----- > > 3rdparty/stout/include/stout/protobuf.hpp > fcd91d5ea822612e4b32d157fcbc5f0dedeba823 > 3rdparty/stout/tests/protobuf_tests.cpp > 55889dc432a9459965d3dd75052d672828cdea90 > > > Diff: https://reviews.apache.org/r/71906/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
