----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71907/#review219120 -----------------------------------------------------------
Ship it! Ship It! - Andrei Sekretenko On Dec. 12, 2019, 11:12 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71907/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2019, 11:12 p.m.) > > > Review request for mesos, Andrei Sekretenko and Greg Mann. > > > Bugs: MESOS-6568 > https://issues.apache.org/jira/browse/MESOS-6568 > > > Repository: mesos > > > Description > ------- > > Per MESOS-6568, we now produce empty arrays and maps in json when > there are empty repeated fields and empty maps in protobuf. This > means that some of the tests need to be updated since they either > expect exact json comparisons to match, or expect no additional > keys to be present. > > > Diffs > ----- > > src/tests/common/http_tests.cpp 5f3652732641f763343f98651dab2472131b38e3 > src/tests/master_quota_tests.cpp 2b30c25d91452fef1387bb321830b9846237fc46 > src/tests/reservation_endpoints_tests.cpp > c8e5ece4499c2822cc2f7d2ad1d49258420142f3 > > > Diff: https://reviews.apache.org/r/71907/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
