----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71538/#review219132 -----------------------------------------------------------
Fix it, then Ship it! configure.ac Lines 271 (patched) <https://reviews.apache.org/r/71538/#comment307231> Why not just `--enable-nvml`/`--disable-nvml`? - Benno Evers On Sept. 24, 2019, 10:08 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71538/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2019, 10:08 p.m.) > > > Review request for mesos, Gilbert Song and Kevin Klues. > > > Bugs: MESOS-9978 > https://issues.apache.org/jira/browse/MESOS-9978 > > > Repository: mesos > > > Description > ------- > > NVML is distributed under a license which is probably not "free" which > can e.g., be aan obstacle when including Mesos using symbols from it in > certain distributions. > > This patch adds a configure flag to disable use of the NVML headers > completely. Note that with this flag disabled it is impossible to use > GPU isolation with the Mesos containerizer. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 23ef7c1e5c6fe1555b6f2458f2a858471783ae2a > 3rdparty/Makefile.am 0de005dad9775f9f7e1a77a242e3b345219c7ac3 > cmake/CompilationConfigure.cmake 62cb23e81abb2c7e4e8e13c83b45afb98708bd30 > configure.ac f274f34e6982beb0a5a683526f7eb9c4ea744e40 > docs/configuration/autotools.md 55a5de83729271b043bd1b8de67798ab52b195c6 > docs/configuration/cmake.md 554c3bf458bc85609225a19ad4843029772ab51c > src/CMakeLists.txt ef9382dc77d37fed344b7267119f3251acd3088a > src/Makefile.am eff0127a0baa7c112db32aa1bd2b35e0d3cb7aee > src/slave/containerizer/mesos/containerizer.cpp > 16149a1428db687b131de08d14893a2dd684ce28 > src/slave/containerizer/mesos/isolators/gpu/nvml.hpp > eb5c0b008abc651d826c399f4538ad8916469b86 > src/slave/containerizer/mesos/isolators/gpu/nvml.cpp > 48a5bf6720e5c9a9ceec24740d47c14f0ad097b7 > src/tests/environment.cpp c3596fb94020d2433f15e630516b1320875a9fa3 > > > Diff: https://reviews.apache.org/r/71538/diff/1/ > > > Testing > ------- > > * tested toggle both ways in cmake and autotools build > * wasn't able to test test filter since I don't seem to have access to a dev > machine with GPUs > > > Thanks, > > Benjamin Bannier > >
