----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/#review219164 -----------------------------------------------------------
src/slave/slave.cpp Lines 126 (patched) <https://reviews.apache.org/r/71858/#comment307273> Since we have other places in the code where we do `using std::map;`, it seems a bit awkward to me to refer to this type as just `Map`. I think we should just fully qualify this typename in the code, and get rid of this `using` directive. - Greg Mann On Dec. 31, 2019, 9:08 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71858/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2019, 9:08 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10046 > https://issues.apache.org/jira/browse/MESOS-10046 > > > Repository: mesos > > > Description > ------- > > WIP: Set resource limits when launching executor container. > > > Diffs > ----- > > src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb > src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 > > > Diff: https://reviews.apache.org/r/71858/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
