----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71971/#review219174 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/attributes.hpp Lines 47-48 (patched) <https://reviews.apache.org/r/71971/#comment307292> nit: can you put the period at the end of the sentence, after the closing paren? 3rdparty/stout/include/stout/attributes.hpp Lines 52 (patched) <https://reviews.apache.org/r/71971/#comment307293> This makes `STOUT_DEPRECATED` a noop on all current clang versions. We could add another `TODO` here to figure out what until which release clang emitted the warning (I did not see it with clang-10.0.0). - Benjamin Bannier On Jan. 8, 2020, 1:15 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71971/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2020, 1:15 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Added a special case for the `[[deprecated]]` attribute to > handle configurations where clang claims to support this > attribute but also emits a warning that it should not be used. > > > Diffs > ----- > > 3rdparty/stout/include/stout/attributes.hpp > 54d438dca56d5346c58eb28eaeda7916a3a62076 > > > Diff: https://reviews.apache.org/r/71971/diff/1/ > > > Testing > ------- > > Internal unit test run in progress. > > > Thanks, > > Benno Evers > >
