> On Jan. 7, 2020, 9:43 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3623 (patched) > > <https://reviews.apache.org/r/71858/diff/4/?file=2191535#file2191535line3628> > > > > Should this be an `Option`? So that we can only set > > `containerConfig.limits` when limits have actually been set? > > Qian Zhang wrote: > I added a check `if (!executorLimits.empty()) {` before setting > `containerConfig.limit`, HDYT?
If we use an option, then the type in the function signature more precisely expresses the semantics of the function, which improves readability IMO. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/#review219154 ----------------------------------------------------------- On Jan. 8, 2020, 2:40 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71858/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2020, 2:40 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10046 > https://issues.apache.org/jira/browse/MESOS-10046 > > > Repository: mesos > > > Description > ------- > > WIP: Set resource limits when launching executor container. > > > Diffs > ----- > > src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb > src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 > > > Diff: https://reviews.apache.org/r/71858/diff/6/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
