----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219229 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 254-255 (patched) <https://reviews.apache.org/r/71966/#comment307395> A newline between. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 255 (patched) <https://reviews.apache.org/r/71966/#comment307396> Same comment as this one: https://reviews.apache.org/r/71965/#comment307388 . src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Line 283 (original), 313-314 (patched) <https://reviews.apache.org/r/71966/#comment307397> A newline between. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 315 (patched) <https://reviews.apache.org/r/71966/#comment307399> Shouldn't it be a warning instead? - Qian Zhang On Jan. 8, 2020, 1:06 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71966/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2020, 1:06 a.m.) > > > Review request for mesos, Greg Mann and Qian Zhang. > > > Bugs: MESOS-10079 > https://issues.apache.org/jira/browse/MESOS-10079 > > > Repository: mesos > > > Description > ------- > > This patch enables recovery for nested cgroups and implements > the detection of orphaned nested cgroups. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 4bd3d6dad37dee031660c15e957cc36f63e21fcb > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > b12b73d8e0161d448075378765e77867521de04e > > > Diff: https://reviews.apache.org/r/71966/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
