----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72055/#review219405 -----------------------------------------------------------
Patch looks great! Reviews applied: [72055] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Jan. 28, 2020, 2:13 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72055/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2020, 2:13 p.m.) > > > Review request for mesos, Andrei Sekretenko, Greg Mann, Qian Zhang, and Vinod > Kone. > > > Bugs: MESOS-9847 > https://issues.apache.org/jira/browse/MESOS-9847 > > > Repository: mesos > > > Description > ------- > > Previously, the Docker executor terminated itself after a task's > container had terminated. This could lead to termination of the > executor before receiving all status update acknowledgments from > the agent. In order to mitigate this issue, the executor slept for > one second to give a chance to send all status updates and receive > all status update acknowledgments before terminating itself. This > might have led to various race conditions in some circumstances > (e.g., on a slow host). This patch terminates the Docker executor > after receiving a terminal status update acknowledgment. Also, > this patch removes the unnecessary call of sleep. > > > Diffs > ----- > > src/docker/executor.cpp 132f42bfa42c846fc5dc40f7763aa0b5d12a7798 > src/exec/exec.cpp 69e5e24b248c7c913421de5e42713c34fd79ad46 > > > Diff: https://reviews.apache.org/r/72055/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
