----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72077/#review219477 -----------------------------------------------------------
src/uri/fetchers/docker.cpp Lines 633-660 (patched) <https://reviews.apache.org/r/72077/#comment307641> I would suggest to move these static methods to the beginning of this file alone with other static methods, like: `getAuthHeaderBasic()`, `getAuthHeaderBearer()`, etc. src/uri/fetchers/docker.cpp Lines 633-634 (patched) <https://reviews.apache.org/r/72077/#comment307642> `"{"` should be in a newline. - Qian Zhang On Feb. 4, 2020, 1:54 a.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72077/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2020, 1:54 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10092 > https://issues.apache.org/jira/browse/MESOS-10092 > > > Repository: mesos > > > Description > ------- > > This is a prerequisite for adding fallback authorization server URI > generation (see MESOS-10092) in the next patches, which will need one > more URI extractor similar to `getManifestUri()`/`getBlobUri()`. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874 > > > Diff: https://reviews.apache.org/r/72077/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
