----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72130/#review219584 -----------------------------------------------------------
Ship it! For the summary / commit message how about something with Fixed to signal to the reader that this is fixing a bug? E.g. "Fixed framework disconnection/removal logic to terminate heartbeater." - Benjamin Mahler On Feb. 13, 2020, 12:36 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72130/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2020, 12:36 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 and MESOS-10097 > https://issues.apache.org/jira/browse/MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10097 > > > Repository: mesos > > > Description > ------- > > This patch gets rid of idle-looping heartbeater processes > that previously could occur after HTTP framework disconnection > (see MESOS-10097). > > > Diffs > ----- > > src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e > > > Diff: https://reviews.apache.org/r/72130/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Sekretenko > >
