----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72096/#review219618 -----------------------------------------------------------
src/master/framework.cpp Lines 572-573 (original), 586-588 (patched) <https://reviews.apache.org/r/72096/#comment307811> From the comments on the previous review, if we want to not hold on to object approvers for disconnected frameworks (i.e. for overhead reasons), then seems like this would be updated upon connecting rather than activation? src/master/master.cpp Lines 2666-2668 (patched) <https://reviews.apache.org/r/72096/#comment307813> Reading the call sites, I would have expected that the caller has to log the error rather than it being logged in this helper (I think we generally follow this for e.g. validation helpers). `Option<Error>` seems a bit cleaner, but if it ends up making the call sites a lot more verbose then this seems ok too src/master/master.cpp Lines 2667 (patched) <https://reviews.apache.org/r/72096/#comment307812> Might want to also include the ID here if it's present src/tests/master_authorization_tests.cpp Lines 1091 (patched) <https://reviews.apache.org/r/72096/#comment307814> brace on next line src/tests/master_load_tests.cpp Line 154 (original), 154 (patched) <https://reviews.apache.org/r/72096/#comment307815> brace on next line - Benjamin Mahler On Feb. 12, 2020, 5:58 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72096/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2020, 5:58 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > This is a prerequisite to synchronous authorization of scheduler API > calls (see MESOS-10056). > > > Diffs > ----- > > src/master/framework.cpp a9318a9d33122610960e01a184b568a8ea18b514 > src/master/master.hpp f1aa40fb45c693bd992b50cffca11020a1fe4433 > src/master/master.cpp 6d45c4e56432cb997769f7c6d0c8f71bdc8f8005 > src/tests/master_authorization_tests.cpp > bc8155b97c9078eaa151cc4a3e5bc6ea0d7ac9fa > src/tests/master_load_tests.cpp 6bbc1c061684e0c55edde6ab31ef51542d0be980 > > > Diff: https://reviews.apache.org/r/72096/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
