----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72099/#review219621 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 9098-9102 (original), 8907-8911 (patched) <https://reviews.apache.org/r/72099/#comment307823> Re-number? Note that the comments below also reference the numbers and need to be adjusted so as to not be wrong! - Benjamin Mahler On Feb. 12, 2020, 6 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72099/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2020, 6 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > Now that ACCEPT is authorized synchronously, there are no pending > tasks in-between dispatches on `Master` methods, thus the pending task > tracking code is not needed anymore. > > > Diffs > ----- > > include/mesos/master/master.proto 8c22802625c80c7fcd64d947b693ab4f5d069142 > include/mesos/v1/master/master.proto > 40de3580681fbb066d8f49c5df8d0c97cd766703 > src/master/http.cpp 81ab26a140bf0ac9eb6b64ce17e0388f36d82f5d > src/master/master.hpp f1aa40fb45c693bd992b50cffca11020a1fe4433 > src/master/master.cpp 6d45c4e56432cb997769f7c6d0c8f71bdc8f8005 > src/master/readonly_handler.cpp 341a75af7cb958ad3d9a6803ad88704bcc809595 > src/master/validation.hpp b2897132a6bfaa1002663d6aea0fb87246b3d8d8 > src/master/validation.cpp 2f80536dd3810180385351765965ed6211d372c7 > src/tests/master_validation_tests.cpp > e92ff5913ea43f50b0895d7a2b2dd0efd7361083 > > > Diff: https://reviews.apache.org/r/72099/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
