> On Feb. 24, 2020, 7:26 p.m., Andrei Sekretenko wrote: > > src/slave/http.cpp > > Lines 1978-1988 (patched) > > <https://reviews.apache.org/r/72065/diff/1/?file=2210097#file2210097line1978> > > > > Is it possible to factor this out to make it clear that framework lists > > for `jsonifyGetExectorts` and `serializeGetExecutors` are identical?
Yeah, this could also be done in the master code, but since I simplified it to a pretty small piece of code, I left it duplicated for now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72065/#review219625 ----------------------------------------------------------- On Jan. 30, 2020, 9:31 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72065/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2020, 9:31 p.m.) > > > Review request for mesos, Andrei Sekretenko and Greg Mann. > > > Bugs: MESOS-10026 > https://issues.apache.org/jira/browse/MESOS-10026 > > > Repository: mesos > > > Description > ------- > > This follow the same approach used for the master's v1 calls: > > https://github.com/apache/mesos/commit/6ab835459a452e53fec8982a5aaa > https://github.com/apache/mesos/commit/3dda3622f5ed01e8c132dc5ca594 > > That is, serializing directly to protobuf or json from the in-memory > v0 state. > > > Diffs > ----- > > src/slave/http.hpp 0afdad9479f0cc2c94452b6b1f2289dd6ea01494 > src/slave/http.cpp 04ad0d816618a1880913857a6f0ff38c4643c488 > > > Diff: https://reviews.apache.org/r/72065/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
