----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72068/#review219654 -----------------------------------------------------------
Ship it! Ship It! - Andrei Sekretenko On Jan. 30, 2020, 10:22 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72068/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2020, 10:22 p.m.) > > > Review request for mesos, Andrei Sekretenko and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Per MESOS-10026, we replaced the old protobuf object construction > code with a direct serialization approach to improve performance. > This patch removes the old object construction code (I originally > kept it in case we needed it to debug, but at this point I'm more > confident that we don't need it). > > > Diffs > ----- > > src/master/http.cpp eeaac88c893b43170e655f8bff1d57dd0f7bbfb2 > src/master/master.hpp c813e9fc855cfb1701ec32be7f690e06b6eb203f > src/slave/http.hpp 0afdad9479f0cc2c94452b6b1f2289dd6ea01494 > src/slave/http.cpp 04ad0d816618a1880913857a6f0ff38c4643c488 > > > Diff: https://reviews.apache.org/r/72068/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
