----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72170/#review219690 -----------------------------------------------------------
Patch looks great! Reviews applied: [72130, 72094, 72095, 72089, 72093, 72096, 72097, 72169, 72098, 72099, 72170] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Feb. 28, 2020, 1:09 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72170/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2020, 1:09 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > As per MESOS-10056, authorizer is now responsible for keeping > `ObjectApprover`s valid throughout their lifetime, which might be quite > expensive for custom authorizer implementations that get permissions > from an external IAM. > > This test makes sure that ObjectApprovers of a disconnected framework > are removed. > > > Diffs > ----- > > src/tests/master_authorization_tests.cpp > bc8155b97c9078eaa151cc4a3e5bc6ea0d7ac9fa > > > Diff: https://reviews.apache.org/r/72170/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
