> On March 5, 2020, 3:56 p.m., Greg Mann wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 489-496 (patched) > > <https://reviews.apache.org/r/71953/diff/3/?file=2207336#file2207336line489> > > > > Does it make sense to put this part in either the 'MemoryForward' or > > 'MemoryBackward' tests, instead of here? Or to create a new test which > > verifies basic memory isolator behavior? > > Qian Zhang wrote: > Hmm, I think that is not the purpose of the 'MemoryForward' or > 'MemoryBackward' tests. Actually in the other new tests that I added > (`ROOT_CGROUPS_CFS_CommandTaskLimits` and > `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`), I verifiied both CPU and memory > and also OOM score adjustment, maybe I should rename this test from > `ROOT_CGROUPS_CFS_EnableCfs` to `ROOT_CGROUPS_CFS_CommandTaskNoLimits` and > verify memory in it as well? So this test can be used to verify the backward > compatibility (i.e., the behavior of command task without resource limits > specified is not changed). HDYT?
Renaming the test sounds good to me! - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/#review219798 ----------------------------------------------------------- On Jan. 15, 2020, 2:24 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71953/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2020, 2:24 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10047 > https://issues.apache.org/jira/browse/MESOS-10047 > > > Repository: mesos > > > Description > ------- > > Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > f72e6cdab417368e63349915114aeed586e0ef0e > > > Diff: https://reviews.apache.org/r/71953/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
