----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71952/#review219882 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.hpp Lines 782-784 (original), 782-785 (patched) <https://reviews.apache.org/r/71952/#comment308126> At this point, I think a comment for this helper would be useful, to explain why we have both `taskInfos` and `tasks` arguments. Maybe something like: ``` // This function is used to compute limits for executors // before they are launched as well as when updating // running executors, so we must accept both `TaskInfo` // and `Task` types to handle both cases. ``` src/slave/slave.cpp Line 9989 (original), 10049-10050 (patched) <https://reviews.apache.org/r/71952/#comment308127> Let's add a `CHECK_NOTNULL(task);` here. - Greg Mann On March 9, 2020, 2:08 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71952/ > ----------------------------------------------------------- > > (Updated March 9, 2020, 2:08 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10050 > https://issues.apache.org/jira/browse/MESOS-10050 > > > Repository: mesos > > > Description > ------- > > Set resource limits when updating executor container. > > > Diffs > ----- > > src/slave/slave.hpp 03279db082bdba23dbfeb2d93081a908e609aec2 > src/slave/slave.cpp a914de4bae5630126ae26b9e7dee8c8784ce1ee0 > > > Diff: https://reviews.apache.org/r/71952/diff/7/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
